Skip to content

added solution#1816

Open
Inna-code10 wants to merge 5 commits into
mate-academy:masterfrom
Inna-code10:develop
Open

added solution#1816
Inna-code10 wants to merge 5 commits into
mate-academy:masterfrom
Inna-code10:develop

Conversation

@Inna-code10

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation has a critical issue that must be fixed. In src/components/PeopleTable.tsx, the PersonLink component uses the standard Link component instead of SearchLink. This causes search params (filters and sorting) to be lost when a user clicks on a person's name to view their details, violating requirement #2 which states search params should be preserved when navigating within the People page.

To fix this, import SearchLink from '../SearchLink' and replace the Link component with SearchLink using params={{}} to preserve the current search parameters:

import { SearchLink } from '../SearchLink';

// Instead of:
<Link to={`/people/${slug}`}>{name}</Link>

// Use:
<SearchLink to={`/people/${slug}`} params={{}}>{name}</SearchLink>

Additionally, the Cypress test failure shows the navbar is overlapping clickable elements (z-index issue). Ensure the navbar has position: sticky or fixed with a proper z-index value so content doesn't scroll underneath it and block interactions.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment on lines +7 to +9
people: Person[];
selectedSlug?: string;
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PersonLink uses standard Link instead of SearchLink, which loses search params when navigating to individual people. Requirement #2 states search params should be kept when selecting a person. Use SearchLink from '../SearchLink' with params={{}} to preserve current search params.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The navbar is visually covering person links, preventing user interaction. This is due to incorrect z-index stacking context. The .people-table or its parent should have a defined z-index (e.g., position: relative; z-index: 1) to ensure the table content appears above the navbar. Fixing this will resolve the failing Cypress test while maintaining all other functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved with an educational override to help you progress while learning. All core filtering and sorting functionality works correctly—you've implemented name filtering, century filtering with multi-select, and the three-state sorting cycle (ascending → descending → disabled) using URL search params exactly as required. However, there's a z-index stacking issue: the navbar has z-index: 1000 while .table-container in App.scss only has z-index: 1, causing person links to remain inaccessible behind the navbar. You need to increase the table container's z-index to at least 1001 or higher to ensure it appears above the fixed navbar. This is the root cause of the one failing Cypress test. Once you fix the z-index value, all 70 tests should pass. Great work on the implementation overall!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to pass all tests before requesting the review

@Inna-code10 Inna-code10 requested a review from brespect June 9, 2026 16:32

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants